Updated test to include CK/AITER V2/V3 test in single backend case#454
Updated test to include CK/AITER V2/V3 test in single backend case#454
Conversation
Micky774
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
| # FusedAttention backend | ||
| if fused_attn_supported: | ||
| if len(fused_attn_backends) == 1: | ||
| if len(fused_attn_backends) == 1 and FusedAttnBackend["CK"] not in fused_attn_backends: |
There was a problem hiding this comment.
FusedAnntBackend["CK"] should be guarded - it is invalid key on NV platform.
| ) | ||
| if len(fused_attn_backends) == 2: | ||
| # We can consider the CK backend as being two, since we have V2/V3 kernels | ||
| elif len(fused_attn_backends) == 1: |
There was a problem hiding this comment.
To avoid code duplication it should rather be outside of len(fused_atn_backends) but under separate 'if IS_HIP_EXTENSION and FusedAnndBackends["CK"] in fused_attention_backends'
There was a problem hiding this comment.
Doesn't seem so. The code is still duplicated for len(fused_attn_backends) of 1 and 2
|
How many previously skipped test cases are run with that change? It only allows running configs that are not supported by AOTriton but supported by Unfused or FA. |
Good point, I've updated the skip conditions to double-count CK directly. |
3 participants
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: