Use ros::SteadyTime for calculating update period#29
Open
matthew-reynolds wants to merge 1 commit intoRIVeR-Lab:indigo-develfrom
Open
Use ros::SteadyTime for calculating update period#29matthew-reynolds wants to merge 1 commit intoRIVeR-Lab:indigo-develfrom
matthew-reynolds wants to merge 1 commit intoRIVeR-Lab:indigo-develfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A monotonic time source should be used for calculating the update period passed into the controller manager. This ensures the period is always accurate, and isn't impacted by time smears or time jumps in the wall time. These irregularities in the wall time are not that uncommon, for example when the system time gets synchronized via NTP.
ros::SteadyTimeensures these irregularities don't break the controller update calculations.