Merged
Conversation
things seem to be working pretty good
Collaborator
Author
|
Stressed the "review before merging" just to prevent any potential yolo merges. |
Brought the readme up to date with my changes, adding new images and instructions where appropriate.
rileygramlich
requested review from
PkHutch and
rileygramlich
and removed request for
rileygramlich
There is further refactoring to be done that this point, namely something like generate-coverage, test, and valgrind, all are very similar commands.
Update from the makefile changed the output to geo_dash, this removes it from being tracked.
The addition of the depenency does not include Valgrind in the instructions, this updates the README.md to include it.
PkHutch
previously approved these changes
Jan 28, 2026
Collaborator
PkHutch
left a comment
PkHutch
left a comment
There was a problem hiding this comment.
https://github.com/RIPE-COMP2659/comp2659/pull/35/commits
I will let you take a look at these changes before we merge, importantly, I threw a low-priority issue here: #38
changes: - added disclaimer to the readme that valgrind first and foremost ought to be run with the full game on local machines- not offloaded to automated starting Sidenote: valgrind currently just runs on the testing executable for now, to avoid timing out when we begin developing the game
Collaborator
Author
Note:I'm not sure- but I think this may close issue 38. @PkHutch may have to talk with @sudonym-i to see whether this is the case |
Collaborator
I agree, closes #38 for the time being. We might want a Makefile refactor as we get further along, but it's inconsequential for the time being. |
PkHutch
approved these changes
Jan 29, 2026
Collaborator
PkHutch
left a comment
PkHutch
left a comment
There was a problem hiding this comment.
LGTM via previous review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REVIEW before merging
This branch has some experimental changes:
closes #33