Skip to content

Conversation

@yacchin1205
Copy link
Collaborator

@yacchin1205 yacchin1205 commented Oct 21, 2025

RDM Providerにおけるハッシュ計算を .binder (binder) 構成ベースに対応します。 RCOSDP/CS-repo2docker#22 の変更を利用するようにします。

最新repo2docker(2025.10.0)はイメージ作成時はデータは取り込まず、Jupyter Server起動時に取り込む仕様に変更になりました。そのため、JupyterHubのSpawner設定では以下のコマンドで provision.shの取り込みを行う必要がある点に留意ください。

class Binder**Spawner(KubeSpawner):
...
    cmd = [
        'bash', '-c',
        """
set -e

# Find and execute provision.sh if it exists
for path in \
    "${REPO_DIR}/binder/provision.sh" \
    "${REPO_DIR}/.binder/provision.sh" \
    "$HOME/binder/provision.sh" \
    "$HOME/.binder/provision.sh"; do

    if [ -f "$path" ]; then
        echo "[provision-wrapper] Executing: $path" >&2
        exec bash "$path" "$@"
    fi
done

# No provision.sh found, start normally
exec "$@"
        """,
        '--', 'jupyterhub-singleuser'
    ]
...

@yacchin1205 yacchin1205 changed the title (WIP) Use async RDM detect for hash-based ref [GRDM-55309] RDM Providerにおけるハッシュ計算をメタデータベースに修正 Oct 22, 2025
@yacchin1205 yacchin1205 changed the title [GRDM-55309] RDM Providerにおけるハッシュ計算をメタデータベースに修正 [GRDM-55309] RDM Providerにおけるハッシュ計算を .binder (binder) 構成ベースに対応 Oct 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 61.81818% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.43%. Comparing base (773c6fb) to head (227beac).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
binderhub/repoproviders.py 62.26% 20 Missing ⚠️
binderhub/builder.py 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   77.59%   78.43%   +0.83%     
==========================================
  Files          44       28      -16     
  Lines        3616     3329     -287     
  Branches       47        0      -47     
==========================================
- Hits         2806     2611     -195     
+ Misses        785      718      -67     
+ Partials       25        0      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yacchin1205 yacchin1205 marked this pull request as ready for review November 4, 2025 11:48
@yacchin1205 yacchin1205 requested a review from ikfj November 5, 2025 04:31
@ikfj ikfj merged commit 496e2be into RCOSDP:master Nov 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants