Skip to content

Conversation

@yacchin1205
Copy link
Collaborator

@yacchin1205 yacchin1205 commented Feb 11, 2025

BinderrHubの最新コード (~2025-02-11のものまで) の取り込みを行いました。

consideRatio and others added 30 commits May 28, 2024 14:42
Misc detail fixes in docs and test config
Update podman/stable version from v5.0.2 to v5.0.3
Update library/docker version from 26.1.1-dind to 26.1.3-dind
Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.4 to 6.4.1.
- [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst)
- [Commits](tornadoweb/tornado@v6.4.0...v6.4.1)

---
updated-dependencies:
- dependency-name: tornado
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…m-chart/images/binderhub/tornado-6.4.1

chore(deps): bump tornado from 6.4 to 6.4.1 in /helm-chart/images/binderhub
add allowed list as alternative to banned list of repos
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.2.1...2.2.2)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…m-chart/images/binderhub/urllib3-2.2.2

chore(deps): bump urllib3 from 2.2.1 to 2.2.2 in /helm-chart/images/binderhub
Update library/docker version from 26.1.3-dind to 27.0.2-dind
Update podman/stable version from v5.0.3 to v5.1.1
consideRatio and others added 21 commits January 30, 2025 13:11
GitHub: only show "master" branch message if master branch is requested
…iders

strip trailing slash on github/gist/gitlab URLs
based on review.

Thanks to @manics.
Update podman/stable version from v5.3.1 to v5.3.2
Update library/docker version from 27.4.1-dind to 27.5.1-dind
Expand documentation to cover local test and development
updates:
- [github.com/asottile/pyupgrade: v3.17.0 → v3.19.1](asottile/pyupgrade@v3.17.0...v3.19.1)
- [github.com/psf/black: 24.8.0 → 25.1.0](psf/black@24.8.0...25.1.0)
- [github.com/pycqa/isort: 5.13.2 → 6.0.0](PyCQA/isort@5.13.2...6.0.0)
- [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0)
…te-config

[pre-commit.ci] pre-commit autoupdate
and test detect.regex pattern behavior
cordoning doesn't happen if $DOCKER_IMAGE_CLEANER_NODE_NAME is undefined

single-node clusters (k3s) maybe don't want to be unavailable while cleaning

adds extraEnv passthrough for good measure, in case of future options
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 75.22236% with 390 lines in your changes missing coverage. Please review.

Project coverage is 77.59%. Comparing base (cb20927) to head (773c6fb).

Files with missing lines Patch % Lines
binderhub/builder.py 72.37% 50 Missing ⚠️
binderhub/static/js/components/BuilderLauncher.jsx 32.39% 47 Missing and 1 partial ⚠️
binderhub/build.py 75.52% 47 Missing ⚠️
binderhub/app.py 70.99% 38 Missing ⚠️
binderhub/launcher.py 65.93% 31 Missing ⚠️
binderhub/binderspawner_mixin.py 25.00% 30 Missing ⚠️
binderhub/base.py 69.73% 23 Missing ⚠️
binderhub/registry.py 80.18% 21 Missing ⚠️
binderhub/build_local.py 82.75% 15 Missing ⚠️
binderhub/health.py 79.16% 15 Missing ⚠️
... and 15 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #23       +/-   ##
===========================================
+ Coverage   60.77%   77.59%   +16.82%     
===========================================
  Files          23       44       +21     
  Lines        2603     3616     +1013     
  Branches        0       47       +47     
===========================================
+ Hits         1582     2806     +1224     
+ Misses       1021      785      -236     
- Partials        0       25       +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yacchin1205 yacchin1205 marked this pull request as ready for review February 12, 2025 05:48
@yacchin1205 yacchin1205 marked this pull request as draft February 12, 2025 07:51
@yacchin1205
Copy link
Collaborator Author

テスト https://github.com/RCOSDP/CS-binderhub/actions/runs/13273151159/job/37076957339?pr=23 に関して、Re-runしても再現したので、確認が済むまでDraftに戻します。

@yacchin1205 yacchin1205 requested a review from ikfj March 5, 2025 09:32
@yacchin1205 yacchin1205 marked this pull request as ready for review March 5, 2025 09:32
@yacchin1205
Copy link
Collaborator Author

yacchin1205 commented Mar 5, 2025

テスト https://github.com/RCOSDP/CS-binderhub/actions/runs/13273151159/job/37076957339?pr=23 に関して、Re-runしても再現したので、確認が済むまでDraftに戻します。

本件はWorkaroundとして linux/arm64 のサポートを外すということになりましたので、そのように対応しました。

@ikfj ikfj merged commit bda782e into RCOSDP:master Mar 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.