Skip to content

Change TEMPEST_TEST_PATTERN and allow record_id based on record field combination #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lpiwowar merged 5 commits into from
May 13, 2025
Merged

Change TEMPEST_TEST_PATTERN and allow record_id based on record field combination #52

lpiwowar merged 5 commits into from
May 13, 2025

Conversation

@dsariel
Copy link
Contributor

@dsariel dsariel commented May 8, 2025 •
edited
Loading

  1. Change TEMPEST_TEST_PATTERN to be less restrictive to accommodate with different path names in logs
  2. Allow record_ids based on record field combination

Fixes #51
Fixes #53

@dsariel
Make TEMPEST_TEST_PATTERN less restrictive
cba1446 
And TOBIKO_TEST_PATTERN as well.

Previous pattrens were too restrictive
  TEMPEST_TEST_PATTERN = "tempest-test"
  TOBIKO_TEST_PATTERN = "tobiko-test"

They missed pathes like
  logs/controller-0/ci-framework-data/tests/test_operator/post-deployment-tempest-tempest//stestr_results.html

After the change patterns will match any path that contains 'tempest' or 'tobiko' in the name of the testsuite.
@dsariel dsariel marked this pull request as draft May 8, 2025 18:06
@dsariel
Scraper.run method gets fields to combine record_id from
2126b11 
Previously record_id was based on record['url'].

This change allows to specify which record fields to use for record_id.

The change is used in ci_logs_scraper to combine url with test_name.
@dsariel dsariel changed the title Make TEMPEST_TEST_PATTERN less restrictive Change TEMPEST_TEST_PATTERN and allow record_id based on record field combination May 12, 2025
@dsariel dsariel marked this pull request as ready for review May 12, 2025 15:05
@dsariel dsariel requested review from jpodivin, lpiwowar and sbekkerm May 12, 2025 15:06
lpiwowar
lpiwowar approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@dsariel dsariel requested review from jpodivin and sbekkerm and removed request for jpodivin and sbekkerm May 13, 2025 14:45
@EmilienM EmilienM requested a review from lpiwowar May 13, 2025 14:58
@lpiwowar lpiwowar merged commit 9622a5e into main May 13, 2025
3 checks passed
@lpiwowar lpiwowar deleted the tempest_scraper branch May 13, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM EmilienM approved these changes

@jpodivin jpodivin Awaiting requested review from jpodivin

@sbekkerm sbekkerm Awaiting requested review from sbekkerm

@lpiwowar lpiwowar Awaiting requested review from lpiwowar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

record_id based only on record['url'] causes to false positives in duplication detection Too restrictive TEMPEST_TEST_PATTERN

4 participants

@dsariel @EmilienM @lpiwowar