Use URL-based UUIDs in VectorDB records and fix argparse flags #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsariel
approved these changes
May 8, 2025
- Fixes query string in SolutionsProvider (was tuple, now string). - Changes get_solutions() return to list[dict] and updates error returns. - Defaults kb_id in SolutionsScraper to '' for string consistency.
- Generate deterministic UUIDs using UUIDv5 based on record['url'] - Replace `type=bool` with `action='store_true'` for argparse flags to ensure proper boolean behavior
EmilienM
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #49