Abstração e coesão #1
Conversation
Reviewer's Guide by SourceryThis pull request refactors the game's code to improve its structure and readability. It introduces new functions to handle specific tasks, such as difficulty selection and event handling. This makes the code more modular and easier to maintain. Sequence diagram for difficulty selectionsequenceDiagram
participant User
participant titulo.py
User->>titulo.py: Selects difficulty (1, 2, 3, or 9)
activate titulo.py
titulo.py->>titulo.py: usa_teclas(event)
activate titulo.py
titulo.py->>titulo.py: seleciona_dificuldade(event.key)
activate titulo.py
titulo.py-->>titulo.py: Returns fps (10, 15, 30, or 70)
deactivate titulo.py
titulo.py-->>User: Returns fps
deactivate titulo.py
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @R4f43lVB - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider extracting the game logic into a separate class to further improve abstraction.
Here's what I looked at during the review
- 🟡 General issues: 8 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 2 issues found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| pygame.display.set_caption('Jogo da cobrinha') | ||
| fps = 15 | ||
|
|
||
| assets = baixar_assets() |
There was a problem hiding this comment.
suggestion (performance): Duplicate asset loading detected.
The function baixar_assets() is called twice consecutively without a change in state between the calls. It would be more efficient to load the assets only once, unless there is a specific reason for refreshing them.
Suggested implementation:
pygame.display.set_caption('Jogo da cobrinha')
fps = 15
assets = baixar_assets()
# Sons e Musica do jogo
pygame.mixer.music.load('assets/musica_jogo6.mp3')
# Configurações das paredes (o player morre quando encosta nas paredes)
while True:
# janela=pygame.display.set_mode((janela_comp,janela_alt))Make sure that there is no other call to baixar_assets() inside the loop or elsewhere causing duplicate asset loading.
| for event in pygame.event.get(): | ||
| if usa_teclas(event) is not None: | ||
| if usa_teclas(event) == False: | ||
| tela = False | ||
| else: | ||
| fps = usa_teclas(event) | ||
| print(fps) |
There was a problem hiding this comment.
suggestion (performance): Avoid redundant calls to usa_teclas(event).
usa_teclas(event) is being called multiple times in the same event loop block, which may lead to inconsistent state or unnecessary repeated operations. Consider storing its result in a variable and using that instead.
| for event in pygame.event.get(): | |
| if usa_teclas(event) is not None: | |
| if usa_teclas(event) == False: | |
| tela = False | |
| else: | |
| fps = usa_teclas(event) | |
| print(fps) | |
| for event in pygame.event.get(): | |
| result = usa_teclas(event) | |
| if result is not None: | |
| if result is False: | |
| tela = False | |
| else: | |
| fps = result | |
| print(fps) |
| Como rodar o jogo: | ||
| Para rodar o jogo basta abrir o repositório e no arquivo Jogo rodar o programa. | ||
| Quando o jogo abrir aparecerá uma tela com o titulo e opções de dificuldade correspodendo: |
There was a problem hiding this comment.
issue (typo): Typo: 'correspodendo' should be 'correspondendo'.
| Quando o jogo abrir aparecerá uma tela com o titulo e opções de dificuldade correspodendo: | |
| Quando o jogo abrir aparecerá uma tela com o titulo e opções de dificuldade correspondendo: |
| 3-Difícil 30 FPS (velocidade e dificuldade elevadas) | ||
| 9-Ipossível 70 FPS (Velocidade e dificuldade extremas, não é para amadores) | ||
| Para seslcionar a dificuldade basta precinar a tecla correspondete caso não seja selecionada o jogo rodará na dificuldade média |
There was a problem hiding this comment.
issue (typo): Typo: 'seslcionar' should be 'selecionar'.
| Para seslcionar a dificuldade basta precinar a tecla correspondete caso não seja selecionada o jogo rodará na dificuldade média | ||
| Após selecionar a dificuldade basta prssionar a tela ENTER |
There was a problem hiding this comment.
issue (typo): Typo: 'prssionar' should be 'pressionar'.
| Após selecionar a dificuldade basta prssionar a tela ENTER | |
| Após selecionar a dificuldade basta pressionar a tela ENTER |
| Como rodar o jogo: | ||
| Para rodar o jogo basta abrir o repositório e no arquivo Jogo rodar o programa. |
There was a problem hiding this comment.
suggestion: Clarify what "arquivo Jogo" refers to.
It's unclear what the user should be looking for. Is it a Python file with a specific name? Providing more context would be helpful.
| Para rodar o jogo basta abrir o repositório e no arquivo Jogo rodar o programa. | |
| -Para rodar o jogo, basta abrir o repositório e executar o arquivo "jogo.py". Se o jogo for um script Python, você pode iniciá-lo com o comando: | |
| python jogo.py |
| # janela=pygame.display.set_mode((janela_comp,janela_alt)) | ||
| pygame.display.set_caption('Jogo da cobrinha') | ||
| fps = 15 | ||
|
|
There was a problem hiding this comment.
issue (complexity): Consider extracting repeated initialization sequences into helper functions to reduce duplication and improve code clarity, such as asset loading and fruit position generation, and then calling these functions in the appropriate places to avoid re-initialization within loops, which simplifies the code and makes it easier to maintain and understand without altering the game's functionality..
The code currently re-initializes the same state (e.g. re-fetching assets and re-setting the fruit position/spawn) multiple times. To reduce duplication and improve clarity without changing functionality, consider extracting these repeated sequences into helper functions. For example:
def init_assets():
return baixar_assets()
def get_new_fruit():
return [random.randrange(1, (janela_comp // 10)) * 10,
random.randrange(1, (janela_alt // 10)) * 10]
# Initial setup
pygame.display.set_caption('Jogo da cobrinha')
fps = 15
assets = init_assets()
fruta_pos = get_new_fruit()
fruta_spawn = TrueThen remove the second occurrences of these initializations in the inner loop. This consolidates state setup and reduces clutter.
| if evento == pygame.K_1: | ||
| return 10 | ||
| elif evento == pygame.K_2: | ||
| return 15 |
There was a problem hiding this comment.
issue (complexity): Consider calling usa_teclas(event) once and storing the result in a variable to avoid redundant processing and simplify control flow within the event loop in the titulo function, as it is currently being called three times for each event, which is inefficient and makes the code harder to read..
You’re calling usa_teclas(event) three times. This redundant processing can be streamlined by calling it once per event. For example, instead of:
for event in pygame.event.get():
if usa_teclas(event) is not None:
if usa_teclas(event) == False:
tela = False
else:
fps = usa_teclas(event)
print(fps)you could store the result in a variable:
for event in pygame.event.get():
resultado = usa_teclas(event)
if resultado is not None:
if resultado is False:
tela = False
else:
fps = resultado
print(fps)This change maintains all functionality while reducing redundant calls and simplifying the control flow.
| # Configurações da janela do jogo | ||
|
|
||
| # Configurações das paredes (o player morre quando encosta nas paredes) | ||
| while True: |
There was a problem hiding this comment.
issue (code-quality): Hoist statements out of for/while loops (hoist-statement-from-loop)
| fps = seleciona_dificuldade(evento.key) | ||
| return fps |
There was a problem hiding this comment.
suggestion (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
| fps = seleciona_dificuldade(evento.key) | |
| return fps | |
| return seleciona_dificuldade(evento.key) |
Coesão:
Inicialmente havia apenas um loop que era responsável por reagir a todas as teclas apertadas no menu (Fechar o jogo, mudar a dificuldade, etc) Foi criada uma nova função que reage à seleção de dificuldade.
Abstração:
De forma similar, antes as teclas apertadas durante o jogo eram gerenciadas por um grande loop dentro do arquivo do jogo, então foi gerada uma nova função para lidar com os comandos de movimento do jogador
Summary by Sourcery
Refactors the game logic to improve code organization and readability. It introduces new functions to handle difficulty selection and player movement commands, which were previously managed within a single loop.
Enhancements: