character or factor ID variables fix #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved a warning in ped2fam when handling character ID variables by conditionally converting IDs to numeric only when appropriate. Updated NEWS.md to document this fix.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 84.58% 84.45% -0.13%
==========================================
Files 25 25
Lines 3930 3957 +27
==========================================
+ Hits 3324 3342 +18
- Misses 606 615 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Refactored ped2fam to better handle cases where IDs are character or factor variables, avoiding coercion to NA and providing clearer warnings. Added comprehensive tests to verify correct behavior with both numeric and string IDs.
Phantom parents created during pedigree repair now inherit famID where available. Updated addParentRow to accept famID, adjusted logic in checkParentIDs and addRowlessParents to assign famID, and expanded tests to verify famID handling for phantom parents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the
ped2famfunction's handling of character or factor ID variables, which previously could lead to warnings or incorrect behavior when converting IDs to numeric. The update ensures more robust handling and user notification in such cases.Bug fix and improved error handling:
ped2famfunction inR/segmentPedigree.Rto detect and warn the user if converting character or factor IDs to numeric results in all IDs becomingNA, helping to prevent silent data issues.NEWS.mdto document the fix for handling character ID variables inped2fam.