Set user session stop timeout in all templates #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmarek
force-pushed
the
shutdown-timeout
branch
2 times, most recently
from
dfbc213 to
fca100a
Compare
Not only in Fedora. The issue happens on Debian recently, and the default timeout of 90s is longer than default VM shutdown timeout of 60s - which means: 1. slow user session stop may prevent other services stopping properly before shutdown timeout expires 2. logs do not include stop timeout message that normally tells which processes remained running - such information would help debugging the issue The timeout applied in Fedora is really short (500ms), make it longer (5s) but apply everywhere.
marmarek
force-pushed
the
shutdown-timeout
branch
from
fca100a to
ebf117a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 70.30% 69.89% -0.41%
==========================================
Files 3 3
Lines 495 495
==========================================
- Hits 348 346 -2
- Misses 147 149 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Jan 7, 2026
use qubes.VMRootExec/qubes.VMRootShell services when root needed
QubesOS/qubes-core-admin-client#403
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026010704-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests12 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 21 fixed
Unstable testsDetails
Performance TestsPerformance degradation:16 performance degradations
Remaining performance tests:94 tests
|
This was referenced Jan 7, 2026
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only in Fedora.
The issue happens on Debian recently, and the default timeout of 90s is
longer than default VM shutdown timeout of 60s - which means:
before shutdown timeout expires
processes remained running - such information would help debugging
the issue
The timeout applied in Fedora is really short (500ms), make it longer
(5s) but apply everywhere.