Skip to content

Integration tests for audio-initial-volume feature #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alimirjamali wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Integration tests for audio-initial-volume feature #768

alimirjamali wants to merge 2 commits into from
+85 −0

Conversation

@alimirjamali
Copy link
Contributor

@alimirjamali alimirjamali commented Dec 21, 2025

@alimirjamali alimirjamali force-pushed the issue-2724-domu-speaker-volume branch from 4b13b0d to e466e6d Compare December 21, 2025 20:44
@codecov
Copy link

codecov bot commented Dec 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.58%. Comparing base (64f77f1) to head (6a38ab0).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
- Coverage   70.68%   70.58%   -0.10%     
==========================================
  Files          61       61              
  Lines       13809    13844      +35     
==========================================
+ Hits         9761     9772      +11     
- Misses       4048     4072      +24
Flag Coverage Δ
unittests 70.58% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alimirjamali alimirjamali force-pushed the issue-2724-domu-speaker-volume branch from e466e6d to d5b9b6c Compare December 22, 2025 02:03
@marmarek
Copy link
Member

marmarek commented Dec 26, 2025

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

@qubesos-bot
Copy link

qubesos-bot commented Dec 26, 2025 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025122716-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update

Failed tests

No failures!

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/158999#dependencies
Nothing fixed

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

This was referenced Dec 26, 2025
Open
Open
@alimirjamali alimirjamali force-pushed the issue-2724-domu-speaker-volume branch 3 times, most recently from 3ccb353 to 9fdd861 Compare December 27, 2025 08:08
@alimirjamali
Copy link
Contributor Author

alimirjamali commented Dec 27, 2025 •
edited
Loading

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

p.s.: Confirmed to be available only to members

@marmarek
Copy link
Member

marmarek commented Dec 27, 2025

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Dec 27, 2025

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

This may not work? Unittests for qubes-core-admin-client has failed due to a mysterious python bug. It is not related to my PR. Happened in backup unittests.

@alimirjamali alimirjamali force-pushed the issue-2724-domu-speaker-volume branch from 9fdd861 to df9e383 Compare December 27, 2025 12:27
@alimirjamali
Copy link
Contributor Author

alimirjamali commented Dec 27, 2025

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

Once more if possible. Thanks (pulse sink stream index was integer, should had been str).

@marmarek
Copy link
Member

marmarek commented Dec 27, 2025

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

@alimirjamali
Integration tests: Reset volume/mute settings
6a38ab0 
Reset testvm1 audio volume and clear mute setting after each test. To
avoid conflicts with subsequent tests
@alimirjamali alimirjamali force-pushed the issue-2724-domu-speaker-volume branch from df9e383 to 6a38ab0 Compare December 27, 2025 15:24
@alimirjamali
Copy link
Contributor Author

alimirjamali commented Dec 27, 2025

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

I made another foolish mistake. The order of pactl subcommand and sink ID was wrong. It is fixed. This should be hopefully the last.

@marmarek
Copy link
Member

marmarek commented Dec 27, 2025

openQArun PR_LABEL=openqa-group-2 TEST=system_tests_audio,system_tests_gui_interactive MACHINE=64bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

openqa-group-2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alimirjamali @marmarek @qubesos-bot