Improve custom analysis #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't sort on comparisons, there's already `StructuralEq` for that kind of comparison.
Gets rid of the previous injection mechanism, and allows skipping all analysis entirely.
A stateful `Context` interface is not useful enough to keep around anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of the old custom analysis injection mechanism in favor of adding a generic type parameter.
This allows us to swap the entire custom analysis machinery, including not doing any at all, and is more ergonomic under anticipated usage. There are some rare edge cases where Rust type inference doesn't pick up on the default type parameter, but hopefully that'll improve with time.