[setup] Move import to FFi directly in Builder#5
Open
anth2o wants to merge 1 commit intoQuantumPhotonicsLab:masterfrom
Open
[setup] Move import to FFi directly in Builder#5anth2o wants to merge 1 commit intoQuantumPhotonicsLab:masterfrom
anth2o wants to merge 1 commit intoQuantumPhotonicsLab:masterfrom
Conversation
f090d5d to
a911c08
Compare
- Move import to FFI directly in Builder - Add matplotlib as a requirement - Complile library in the build step so that `pip install .` also works
a911c08 to
f946f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have an issue when trying to install your package:
This PR should solve this by moving the import in the Builder. I made sure my solution worked by executing
pip install .withoutcffialready installedI also modified the
setup.pyto move the compile operations from the install to the build step, so thatpip install .also works.