rework TensorOperations implementation to use backend and allocator #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
lkdvos
force-pushed
the
ld-tensoroperations
branch
from
9c55363 to
a2a6913
Compare
Jutho
reviewed
Nov 15, 2025
Jutho
previously approved these changes
Nov 15, 2025
Member
Jutho
left a comment
Jutho
left a comment
There was a problem hiding this comment.
Very nice; I think there is one typo/mistake, but otherwise this is indeed a great and long overdue change. Tanks for tackling this.
lkdvos
force-pushed
the
ld-tensoroperations
branch
from
6c54aae to
bb4b7ef
Compare
Jutho
referenced
this pull request
Dec 9, 2025
* initial basic design SectorVector * some additional functionality * relax `foreachblock` signature * replace `SectorDict` with `SectorVector` for eig/svdvals * export `svd_vals` * clean up SectorVector design * small fix * add finitedifferences support * update changelog * some simplifications and extensions * some further fixes * some more fixes * update dates --------- Co-authored-by: Jutho Haegeman <jutho.haegeman@ugent.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one of the TODOs by bringing the
contract!interface more in line with the TensorOperations functionality, which allows us to now use thebackendandallocatorfunctionality a bit more fully.Additionally, I slightly reworked the logic of surrounding
twistto avoid some more allocations in some edge cases where we didn't have to permute A, but we did have to twist it.This is a partial reimplementation of some of the logic in #203 but I kept this PR way more minimal and less opinionated, to already get this merged and then simplify actually looking at the multithreading afterwards.
One other thing I noticed is that our
memcostchecking could use some improvements still: we will never simplify the following case for example, which actually could be implemented as a simplemul!call.This however is somewhat related to the planar reorderings that we are doing anyways, so it might actually pay off to at some point (in a separate PR!) have a look at this.