Skip to content

Initial draft for Anderson Darling test constraint. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kklein wants to merge 150 commits into
base: main
Choose a base branch
from
Draft

Initial draft for Anderson Darling test constraint. #54

kklein wants to merge 150 commits into from

Conversation

@kklein
Copy link
Collaborator

@kklein kklein commented Aug 23, 2022 •
edited
Loading

@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited
Loading

Codecov Report

❌ Patch coverage is 41.73749% with 617 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.67%. Comparing base (deccd34) to head (6c70945).
⚠️ Report is 311 commits behind head on main.

Files with missing lines Patch % Lines
src/datajudge/db_access.py 22.98% 191 Missing ⚠️
src/datajudge/constraints/uniques.py 25.27% 68 Missing ⚠️
src/datajudge/constraints/numeric.py 29.62% 57 Missing ⚠️
src/datajudge/constraints/miscs.py 26.00% 37 Missing ⚠️
src/datajudge/constraints/row.py 33.33% 36 Missing ⚠️
src/datajudge/constraints/date.py 44.06% 33 Missing ⚠️
src/datajudge/constraints/base.py 60.97% 32 Missing ⚠️
src/datajudge/constraints/stats.py 32.55% 29 Missing ⚠️
src/datajudge/constraints/varchar.py 27.02% 27 Missing ⚠️
src/datajudge/constraints/interval.py 42.85% 24 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #54       +/-   ##
===========================================
- Coverage   93.90%   37.67%   -56.23%     
===========================================
  Files          15       21        +6     
  Lines        1607     2118      +511     
===========================================
- Hits         1509      798      -711     
- Misses         98     1320     +1222

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kklein kklein linked an issue Aug 23, 2022 that may be closed by this pull request
Provide 2-sample Anderson Darling test as constraint #45
Open
MariusMerkleQC and others added 27 commits April 3, 2024 16:54
@MariusMerkleQC
Merge pull request #219 from Quantco/docs_improvements
cb8e025 
Fix two minor errors in docs
@kklein
Edit. (#220)
246bb47
@quant-ranger
Pre-commit autoupdate (#221)
723c46d 
Co-authored-by: quant-ranger[bot] <132915763+quant-ranger[bot]@users.noreply.github.com>
@dependabot
Bump google-github-actions/auth from 2.1.2 to 2.1.3 (#222)
17b8ab2 
Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.2 to 2.1.3.
- [Release notes](https://github.com/google-github-actions/auth/releases)
- [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md)
- [Commits](google-github-actions/auth@55bd3a7...71fee32)

---
updated-dependencies:
- dependency-name: google-github-actions/auth
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump mamba-org/setup-micromamba from 1.8.1 to 1.9.0 (#223)
efc54e3 
Bumps [mamba-org/setup-micromamba](https://github.com/mamba-org/setup-micromamba) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/mamba-org/setup-micromamba/releases)
- [Commits](mamba-org/setup-micromamba@4225001...f8b8a1e)

---
updated-dependencies:
- dependency-name: mamba-org/setup-micromamba
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@SimonLangerQC
adding configuration options to uniques functionality
9ea8866
@SimonLangerQC
improve docstrings
92f2933
@SimonLangerQC
move util_ functions to datajudge.utils
63e9634
@SimonLangerQC
updates following comments
3782955
@SimonLangerQC
add configuration options to functional dependency checks, and utilit…
6cad13e 
…y scripts for postgres integration testing from a fresh db every time
@SimonLangerQC @ivergara
fix typo in run_integration_tests_postgres.sh
7dec26e 
Co-authored-by: Ignacio Vergara Kausel <ivergarakausel@gmail.com>
@SimonLangerQC
rename to output_processor
6322310
@SimonLangerQC
output_processor only
308ff99
@SimonLangerQC
allow for single output processor
c1fec1a
@SimonLangerQC
add output_processor_limit
91ea51c
@SimonLangerQC @kklein
Docs update
0f94589 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
693b29b 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
5c0c03b 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
52f993d 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
887b0e6 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
0699ddb 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
3ef980e 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
13d866f 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
582af61 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
a522268 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
0c87d34 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@SimonLangerQC @kklein
Docs update
cdd6e1f 
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
quant-ranger bot and others added 30 commits August 25, 2025 08:20
@quant-ranger @kklein
Update pixi lockfile (#279)
dd63a91 
* Update pixi lockfile

* Update lock

* Don't test db2 against sqlalchemy 1 due to incompatiblity

* Remove inexistent env from ci matrix

---------

Co-authored-by: quant-ranger[bot] <132915763+quant-ranger[bot]@users.noreply.github.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
Co-authored-by: kklein <kevin.klein@quantco.com>
@quant-ranger
Update pixi lockfile (#287)
691f98b 
Co-authored-by: quant-ranger[bot] <132915763+quant-ranger[bot]@users.noreply.github.com>
@dependabot
Bump codecov/codecov-action from 5.4.3 to 5.5.1 (#289)
a45b38b 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.4.3 to 5.5.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v5.4.3...v5.5.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 5.5.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump pypa/gh-action-pypi-publish from 1.12.4 to 1.13.0 (#288)
d24392d 
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.12.4 to 1.13.0.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.12.4...v1.13.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-version: 1.13.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump prefix-dev/setup-pixi from 0.9.0 to 0.9.1 (#290)
589d796 
Bumps [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi) from 0.9.0 to 0.9.1.
- [Release notes](https://github.com/prefix-dev/setup-pixi/releases)
- [Commits](prefix-dev/setup-pixi@v0.9.0...v0.9.1)

---
updated-dependencies:
- dependency-name: prefix-dev/setup-pixi
  dependency-version: 0.9.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github/codeql-action from 3 to 4 (#292)
ad2bae5 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v3...v4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/download-artifact from 5 to 6 (#294)
0926406 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/upload-artifact from 4 to 5 (#295)
56ca8c2 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v5)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump prefix-dev/setup-pixi from 0.9.1 to 0.9.2 (#293)
c7856eb 
Bumps [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi) from 0.9.1 to 0.9.2.
- [Release notes](https://github.com/prefix-dev/setup-pixi/releases)
- [Commits](prefix-dev/setup-pixi@v0.9.1...v0.9.2)

---
updated-dependencies:
- dependency-name: prefix-dev/setup-pixi
  dependency-version: 0.9.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump prefix-dev/setup-pixi from 0.9.2 to 0.9.3 (#296)
6371909 
Bumps [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi) from 0.9.2 to 0.9.3.
- [Release notes](https://github.com/prefix-dev/setup-pixi/releases)
- [Commits](prefix-dev/setup-pixi@v0.9.2...v0.9.3)

---
updated-dependencies:
- dependency-name: prefix-dev/setup-pixi
  dependency-version: 0.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/checkout from 5 to 6 (#298)
4706ec1 
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/download-artifact from 6 to 7 (#301)
19f95b1 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 6 to 7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v6...v7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump codecov/codecov-action from 5.5.1 to 5.5.2 (#300)
62fbc09 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.1 to 5.5.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v5.5.1...v5.5.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 5.5.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/upload-artifact from 5 to 6 (#299)
86f7038 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v5...v6)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kklein
Remove support for Python 3.8 and Python 3.9 (#302)
d39504a 
* Update pixi lock

* Fix typo

* Remove support for deprecated Python versions

* Rm inexistent environment from ci matrix.

* Try to address pool issue by reusing fixture in session.

* Add changelog entry.

* Fix SQLAlchemy connection pool exhaustion in db_access.py (#303)

* Initial plan

* Fix connection pool exhaustion by adding context managers to engine.connect() calls

Co-authored-by: kklein <7267523+kklein@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kklein <7267523+kklein@users.noreply.github.com>

* Apply pchs.

* Add pixi environments and CI for Python 3.14

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
@kklein
Update version.
8ed1c33
@ivergara
First attempt
8f12941
@ivergara
Revert "First attempt"
73c9e9a 
This reverts commit 8f12941.
@ivergara
chore: Improve Snowflake security auth in CI (#305)
c770c9f 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kklein
Discontinue impala support (#307)
e0d1211 
* Remove impala-related environments.

* Remove impala-related code.

* Add changelog entry.
@quant-ranger
Update pixi lockfile (#309)
a0521d5 
Co-authored-by: quant-ranger[bot] <132915763+quant-ranger[bot]@users.noreply.github.com>
@kklein
Clean up minorly (#310)
7a5a5d2 
* Fix typos

* Rm superfluous dependency
@kklein
Add support for DuckDB (#311)
0416325 
* Add support for duckdb

* Clean up minorly (#310)

* Fix typos

* Rm superfluous dependency

* Mention backend support

* Rm some environments from CI to save resources.

* Add changelog entry and increase version number.

* Increase memory limit for DuckDB on unix.
@pavelzw @thomasmarwitz @kklein
Migrate from sphinx to mkdocs (#238)
44d0002 
* Try out mkdocs-material

* WIP

* Render all code documentation, exemplary link within docstring.

Include a link example to another module function (:meth: in sphinx).
Fix some ruff complaints.

* Adapt docstrings as to appease pchs.

* Translate changelog.

* Rm

* Add references to changelog.

* Fix pixi env references.

* Add readthedocs configuration

* Allow for self-reference type annotation.

* Fix typo

* Fix symlink

* Fix index

* Fix indentation

* Tell prettier to give markdown files list items with 4 spaces

* Use full qualification when reffering to FromClause and Select

* Fix field name

* Fix inheritance

* Fix field reference

* Add type hints to signatures.

* Add reference to neighboring article.

---------

Co-authored-by: Thomas Marwitz <thomasmarwitz3@gmail.com>
Co-authored-by: kklein <kevin.klein@quantco.com>
Co-authored-by: Kevin Klein <7267523+kklein@users.noreply.github.com>
@pavelzw @kklein
Add ty as an additional type checker (#306)
706bd0b 
* add ty

* introduce ty

* WIP

* Address some ty complaints.

* Don't expect children to implement retrieve and compare.

* use --no-progress

* Address some more ty complaints.

* Fix another ty complaint.

* Add type annotation.

* Remove type igores.

* Bring back instance caching

* Tell ty that the first argument to a method doesn't correspond to self.

* Remove some mypy hacks

* Update lock

* Add annotation and fix typo

* Fix method references

* Fix imports

* Rework interfaces of select methods

* Ensure that method overwrites are legitimate overwrites

* Fix field references

* Fix more method references.

* Bring back mypy

* Use default environment for mypy

* Use updated lock

---------

Co-authored-by: kklein <kevin.klein@quantco.com>
@kklein
Add deprecation warning for sqlalchemy <2. (#312)
10ee6a9 
* Add deprecation warning for sqlalchemy <2.

* Reorder actions

* Remove dead code

* Fix sentence

* Add changelog entry and increase version number.

* Be more specific in changelog.

* Fix documentation URL in README

* Fix typo

* Fix more typos
@kklein
Merge branch 'anderson_darling' of github.com:Quantco/datajudge into …
5594c5c 
…anderson_darling
@kklein
Fix incompatibilities to changes since PR
8ce9fd7
@kklein
Add type hints
b2abcc0
@kklein
Add simple tests.
6c70945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide 2-sample Anderson Darling test as constraint

6 participants

@kklein @MariusMerkleQC @SimonLangerQC @pavelzw @ivergara