-
Notifications
You must be signed in to change notification settings - Fork 3
Add deprecation warning for sqlalchemy <2. #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 92.56% 92.86% +0.30%
==========================================
Files 21 21
Lines 2057 2061 +4
==========================================
+ Hits 1904 1914 +10
+ Misses 153 147 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We have never tested BigQuery against @ivergara Do you happen to have an idea as to what the necessary next steps to mage BigQuery work in CI consist of? Edit: @pavelzw was so kind to help out :) |
| `datajudge` can either be installed via pypi with `pip install datajudge` or via conda-forge with `conda install datajudge -c conda-forge`. | ||
|
|
||
| Please refer to the [Getting Started](https://datajudge.readthedocs.io/en/latest/getting_started.html) section of our documentation for details. | ||
| Please refer to the [Getting Started](https://datajudge.readthedocs.io/en/latest/getting-started/) section of our documentation for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated correction of a URL that hasn't been updated since the mkdocs migration.
The release of
sqlalchemyversion 2.0.0 dates back more than three years by now. The backend-specific libraries we rely on all have support for sqlalchemy 2.0.0, too.Since supporting both
sqlalchemy1.* and 2.* makes our code more complicated and our testing and CI more involved, I suggest to remove support for it. As a first step, I would like to create a release with a deprecation warning.