Skip to content

Conversation

@kklein
Copy link
Collaborator

@kklein kklein commented Jan 20, 2026

The release of sqlalchemy version 2.0.0 dates back more than three years by now. The backend-specific libraries we rely on all have support for sqlalchemy 2.0.0, too.

Since supporting both sqlalchemy 1.* and 2.* makes our code more complicated and our testing and CI more involved, I suggest to remove support for it. As a first step, I would like to create a release with a deprecation warning.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (706bd0b) to head (e21d2e3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   92.56%   92.86%   +0.30%     
==========================================
  Files          21       21              
  Lines        2057     2061       +4     
==========================================
+ Hits         1904     1914      +10     
+ Misses        153      147       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kklein kklein added the ready label Jan 20, 2026
@kklein
Copy link
Collaborator Author

kklein commented Jan 20, 2026

We have never tested BigQuery against sqlalchemy versions >=2 so far. I think that before we deprecate slqalchemy <2, I think that it'd be great to make sure everything works fine.

@ivergara Do you happen to have an idea as to what the necessary next steps to mage BigQuery work in CI consist of?

Edit: @pavelzw was so kind to help out :)

@kklein kklein marked this pull request as ready for review January 20, 2026 16:51
@kklein kklein requested a review from ivergara January 20, 2026 16:55
`datajudge` can either be installed via pypi with `pip install datajudge` or via conda-forge with `conda install datajudge -c conda-forge`.

Please refer to the [Getting Started](https://datajudge.readthedocs.io/en/latest/getting_started.html) section of our documentation for details.
Please refer to the [Getting Started](https://datajudge.readthedocs.io/en/latest/getting-started/) section of our documentation for details.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated correction of a URL that hasn't been updated since the mkdocs migration.

@kklein kklein merged commit 10ee6a9 into main Jan 20, 2026
61 checks passed
@kklein kklein deleted the deprecate-sa1 branch January 20, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants