add ty

[pavelzw]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 95.09804% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.56%. Comparing base (44d0002) to head (3750c16).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/datajudge/requirements.py	69.23%	4 Missing ⚠️
src/datajudge/db_access.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   92.38%   92.56%   +0.17%     
==========================================
  Files          21       21              
  Lines        2062     2057       -5     
==========================================
- Hits         1905     1904       -1     
+ Misses        157      153       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kklein]

Do we want this?

[kklein]

Hi @copilot - please explain why the changes introduced with this PR revolving around the caching of get_factual_value and get_target_value lead to the test failures in CI.

[Copilot]

@kklein I've opened a new pull request, #308, to work on those changes. Once the pull request is ready, I'll request review from you.

[kklein]

@pavelzw @ivergara It seems to me that the remaining ty complaints are due to it not fully understanding how the methods get_factual_value and get_target_value are overwritten in _setup_caching.

Does one of you have a better idea than adding 4 # type: ignore[missing-argument]?

Unfortunately instance method caching is quite messy.

[kklein]

I find this to be quite dissatisfying :(

[kklein]

Hi @pavelzw - could you ptal at the changes I've made?

[kklein]

@pavelzw kind bump :)

[pavelzw]

looks good, thanks @kklein :)