Open
Conversation
Allow dependencies for objects with no template set and don't silently ignore dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example uses
with_depends_on()a few times and none of those uses do anything. That's because the code tests if the two objects have a template and it's the same template. The example doesn't initially set the template so this test fails silently and the dependencies are not added.I'm not sure why the test was there in the first place. But if there is a good reason for it, I propose supporting no equality when no templates are defined. It should also raise an exception when the templates don't match instead of silently ignoring the dependency.