Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
src/kirin/dialects/func/attrs.py
Outdated
| MethodType = types.Generic( | ||
| Method, types.TypeVar("Params", types.Tuple), types.TypeVar("Ret") | ||
| ) | ||
| # TypeofMethodType = types.PyClass[Method] |
There was a problem hiding this comment.
Can we get rid of the Signature attribute too? Now you have a function type we can just use that to replace the Signature attribute
There was a problem hiding this comment.
that will be breaking tho because it requires to remove the trait too
There was a problem hiding this comment.
my original thought is that trait change can go together with your refactor on stage method, and make this PR simpler
kaihsin
added
C-bug
fixed type hint issue |
|
Oh nice, glad you figure it out! |
Roger-luo
added
the
breaking
2 participants
This PR address #579 and contain partly of #580