Open
Conversation
GiggleLiu
reviewed
Dec 18, 2021
Closed
minhthin1028
commented
Dec 21, 2021
minhthin1028
commented
Dec 21, 2021
| @@ -0,0 +1,43 @@ | |||
| using UnitDiskMapping, Test | |||
Contributor
Author
There was a problem hiding this comment.
Still need to add unit tests for new functions
minhthin1028
commented
Dec 21, 2021
| return MappingResult(ug, vcat(tape, tape2) , mis_overhead0 + mis_overhead1 + mis_overhead2) | ||
| end | ||
|
|
||
| function apply_simplifiers_unweighted(ug::UGrid) |
Contributor
Author
There was a problem hiding this comment.
Wanted an estimate of overhead scaling, can delete/modify function
GiggleLiu
reviewed
Dec 21, 2021
| halfx = (x_max - x_min)/2 + x_min | ||
| halfy = (y_max - y_min)/2 + y_min | ||
|
|
||
| # move boundary vertices such that we can shrink graph from four quadrants |
Contributor
There was a problem hiding this comment.
Good! Now it is much easier to read. If possible, you should try to lessen the number of branches - otherwise you need to write tests for every branch to ensure the test coverage is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.