Skip to content

2024 04 24 fix swmm views #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sjib wants to merge 18 commits into
base: master
Choose a base branch
from
Open

2024 04 24 fix swmm views #232

sjib wants to merge 18 commits into from

Conversation

@sjib
Copy link
Contributor

@sjib sjib commented Apr 24, 2024 •
edited
Loading

SWMM 5.1 / 5.2. seems not to like NULL values if there is no data - therefore replacing defaults with 0 resp. 0.0 instead.

@sjib sjib marked this pull request as draft April 24, 2024 12:30
@sjib sjib added the Fix Fix a bug or something broken label Apr 24, 2024
@ponceta ponceta added this to the 1.6.2 milestone May 13, 2024
@sjib
Copy link
Contributor Author

sjib commented Jun 17, 2024

Documentation update: see QGEP/docs#224

@sjib
Copy link
Contributor Author

sjib commented Jun 17, 2024

@ponceta Do I need to make a full delta?

@sjib sjib self-assigned this Jun 17, 2024
@sjib sjib marked this pull request as ready for review June 17, 2024 17:41
@sjib
Copy link
Contributor Author

sjib commented Aug 2, 2024

@ponceta What is going wrong here?

ponceta
ponceta reviewed Aug 22, 2024
View reviewed changes
@sjib

This comment was marked as resolved.

Sign in to view
@ponceta ponceta closed this Nov 18, 2024
@ponceta ponceta reopened this Nov 18, 2024
@sjib
Copy link
Contributor Author

sjib commented Nov 19, 2024

@ponceta Can you tell me why the Docker tests fail?

@sjib sjib force-pushed the 2024-04-24-fix-swmm-views branch from 1a38c11 to 0f04a86 Compare December 3, 2024 13:47
@sjib
Copy link
Contributor Author

sjib commented Dec 3, 2024 

Run docker exec qgep init_qgep.sh wait
waiting for postgres...
initializing QGEP… 🐘 🐘
Error: Process completed with exit code 137.

@ponceta Any idea why this is not going thru?

@ponceta
Copy link
Member

ponceta commented Dec 3, 2024 

2024-12-03 13:49:02.189 UTC [175] ERROR:  missing FROM-clause entry for table "dp" at character 1927

Check Failure Logs section a little bit lower in the CI Test :
image

@sjib sjib mentioned this pull request Nov 11, 2025
Merged
@sjib
Copy link
Contributor Author

sjib commented Nov 11, 2025

Also backporting some improvements from teksi/wastewater#820

@sjib sjib modified the milestones: 1.6.2, 1.6.4 Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ponceta ponceta ponceta left review comments

Assignees

@sjib sjib

Labels

Fix Fix a bug or something broken

Projects

None yet

Milestone

1.6.4

Development

Successfully merging this pull request may close these issues.

3 participants

@sjib @ponceta