Conversation
There was a problem hiding this comment.
Pull request overview
Updates packaging/lint/build configuration and small runtime adjustments to address build failures and modernize resource handling in Deform.
Changes:
- Clean up lint/build config and whitespace issues (tox, isort config, stray blank lines).
- Remove an invalid/legacy Trove classifier from
setup.py. - Replace
pkg_resources.resource_filenameusage withimportlib.resourcesfor template asset resolution, and adjustValidationFailurebase exception initialization.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Removes trailing whitespace in rstcheck invocation to keep linting strict/clean. |
| setup.py | Drops a legacy/non-standard license classifier from package metadata. |
| pyproject.toml | Adjusts isort configuration by removing lines_after_imports. |
| deform/widget.py | Removes a stray whitespace-only blank line. |
| deform/template.py | Migrates template asset resolution to importlib.resources and updates default template directory resolution. |
| deform/schema.py | Removes a stray whitespace-only blank line. |
| deform/i18n.py | Removes a stray whitespace-only blank line. |
| deform/exception.py | Changes ValidationFailure to populate Exception.args via super().__init__(...). |
Comments suppressed due to low confidence (1)
deform/template.py:8
- The module-level docstring for
ZPTRendererFactorystill states that asset specs are resolved viapkg_resources.resource_filename, but this implementation now usesimportlib.resources. Please update that docstring (and any related docs, if applicable) so it matches the new resolution mechanism.
import os.path
from chameleon.zpt.loader import TemplateLoader
from pkg_resources import resource_filename
from translationstring import ChameleonTranslate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
db2a3bf to
d65c296
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@sbrunner can you also make a final release? |
|
Done for Pypi and GitHub, but I don't know how to do that:
@delijati do you know how to do that? |
|
@sbrunner no |
|
@sbrunner @delijati for docs, please provide your RTD usernames, and I'll send you invitations to become maintainers there. The builds are failing because deform needs a For the demo, I honestly can't remember. I think I documented it somewhere, but I can't find it on |
|
@stevepiercy my RTD usernames is stbrunner :-) |
|
@sbrunner invitation sent! |
|
@stevepiercy delijati in RTD |
|
@delijati invitation sent! |
No description provided.