Skip to content

Fix build#536

Merged
delijati merged 3 commits intomainfrom
bix-build
Feb 10, 2026
Merged

Fix build#536
delijati merged 3 commits intomainfrom
bix-build

Conversation

@sbrunner
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings February 10, 2026 10:02
@sbrunner sbrunner changed the title Bix build Fix build Feb 10, 2026
@sbrunner sbrunner marked this pull request as draft February 10, 2026 10:07
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates packaging/lint/build configuration and small runtime adjustments to address build failures and modernize resource handling in Deform.

Changes:

  • Clean up lint/build config and whitespace issues (tox, isort config, stray blank lines).
  • Remove an invalid/legacy Trove classifier from setup.py.
  • Replace pkg_resources.resource_filename usage with importlib.resources for template asset resolution, and adjust ValidationFailure base exception initialization.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tox.ini Removes trailing whitespace in rstcheck invocation to keep linting strict/clean.
setup.py Drops a legacy/non-standard license classifier from package metadata.
pyproject.toml Adjusts isort configuration by removing lines_after_imports.
deform/widget.py Removes a stray whitespace-only blank line.
deform/template.py Migrates template asset resolution to importlib.resources and updates default template directory resolution.
deform/schema.py Removes a stray whitespace-only blank line.
deform/i18n.py Removes a stray whitespace-only blank line.
deform/exception.py Changes ValidationFailure to populate Exception.args via super().__init__(...).
Comments suppressed due to low confidence (1)

deform/template.py:8

  • The module-level docstring for ZPTRendererFactory still states that asset specs are resolved via pkg_resources.resource_filename, but this implementation now uses importlib.resources. Please update that docstring (and any related docs, if applicable) so it matches the new resolution mechanism.
import os.path

from chameleon.zpt.loader import TemplateLoader
from pkg_resources import resource_filename
from translationstring import ChameleonTranslate

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbrunner sbrunner force-pushed the bix-build branch 2 times, most recently from db2a3bf to d65c296 Compare February 10, 2026 10:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbrunner sbrunner marked this pull request as ready for review February 10, 2026 10:43
@sbrunner sbrunner requested a review from delijati February 10, 2026 10:43
@delijati delijati merged commit 80bb58c into main Feb 10, 2026
30 checks passed
@delijati delijati deleted the bix-build branch February 10, 2026 16:09
@delijati
Copy link
Contributor

@sbrunner can you also make a final release?

@sbrunner
Copy link
Contributor Author

Done for Pypi and GitHub, but I don't know how to do that:

  • Publish new version of docs.
  • Update deform demo site.

@delijati do you know how to do that?

@delijati
Copy link
Contributor

@sbrunner no
maybe @stevepiercy can help

@stevepiercy
Copy link
Member

@sbrunner @delijati for docs, please provide your RTD usernames, and I'll send you invitations to become maintainers there. The builds are failing because deform needs a .readthedocs.yaml file.

For the demo, I honestly can't remember. I think I documented it somewhere, but I can't find it on main. I think we host it on Akamai, formerly Linode. I'd come ask in Discord if no one speaks up https://discord.com/channels/1212201651218153582/1212201651860017266.

@sbrunner
Copy link
Contributor Author

@stevepiercy my RTD usernames is stbrunner :-)

@stevepiercy
Copy link
Member

@sbrunner invitation sent!

@delijati
Copy link
Contributor

@stevepiercy delijati in RTD

@stevepiercy
Copy link
Member

@delijati invitation sent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants