fix: ♻️ Handle exceptions during message edits in Paginator and BaseView timeouts #3019
+27
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3019/head:pr-3019
git checkout pr-3019This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3019/head |
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Paillat-dev
changed the title
Paillat-dev
added
priority: low
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Paillat-dev
requested changes
Dec 29, 2025
Paillat-dev
changed the title
Paillat-dev
changed the title
Paillat-dev
approved these changes
Dec 30, 2025
Paillat-dev
requested changes
Dec 30, 2025
Paillat-dev
requested changes
Jan 1, 2026
Paillat-dev
requested changes
Jan 1, 2026
Member
Paillat-dev
left a comment
Paillat-dev
left a comment
There was a problem hiding this comment.
Ignore my other first comment; merge conflicts
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Paillat-dev
approved these changes
Jan 5, 2026
Member
Paillat-dev
left a comment
Paillat-dev
left a comment
There was a problem hiding this comment.
Approved so long that @NeloBlivion does as well since they're the most knowledgeable on views inner workings and possible edge cases
Comment on lines
+25
to
+26
| - Fixed `BaseView.on_timeout` and `Paginator.on_timeout` behavior: views no longer raise | ||
| errors on timeout. ([#3019](https://github.com/Pycord-Development/pycord/pull/3019)) |
Member
There was a problem hiding this comment.
This is confusing - people might want views to raise errors when the errors are legitimate - just not when the issue is cause by a 404 / 403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.