-
Notifications
You must be signed in to change notification settings - Fork 3
feat: ✨ Subclass datetime.datetime
#224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Subclass datetime.datetime
#224
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/224/head:pr-224
git checkout pr-224This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord-next@refs/pull/224/head |
Co-authored-by: Paillat-dev <me@paillat.dev>
NeloBlivion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just catching strays, make sure to check everything. All public-facing attributes and methods should return DiscordTime, but parameters entered on the user's end can remain as datetime.
Co-authored-by: NeloBlivion <41271523+neloblivion@users.noreply.github.com>
Co-authored-by: DA344 <108473820+DA-344@users.noreply.github.com> Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>
|
Imma take a look tomorrow I think I'm rly tired rn sorry for the delay but seems good so far |
Co-authored-by: Paillat-dev <me@paillat.dev>
Co-authored-by: Paillat-dev <me@paillat.dev>
Co-authored-by: Paillat-dev <me@paillat.dev>
Summary
This PR aims to subclass the builtin datetime.datetime class and move any time-related utils methods there.
See issue #149
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.