[IO] Support dict for HTTP Basic Auth config & fix docs #534
+95
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kloppy supports fetching data from URLs protected with HTTP Basic Auth. Previously, the documentation stated that this requires setting the following configuration:
However, since the configuration variable is unpacked as
aiohttp.BasicAuth(*basic_authentication), the correct way to set the configuration variable was to define it as a tuple:Moreover, the keys used are incorrect, as
aiohttp.BasicAuthuses "login" and "password".I've updated the code such that 'adapters.http.basic_authentication' now accepts both a dict and a tuple, fixed the documentation, and added tests for retrieving data from URLs protected with HTTP Basic Auth.
aiohttp.BasicAuthusing keyword argumentsFixes #78