Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/macos-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Install Project
run: |
python -m pip install -e .
python -m pip install -e ".[test]" || true
python -m pip install -e ".[test]"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid failing CI on undefined test extra

This now fails the macOS workflow because pyproject.toml defines only dev and docs under [project.optional-dependencies] (no test extra). With || true removed, pip install -e ".[test]" will exit non‑zero on every run, stopping the job before tests. If the intent is to install pytest, this should use the existing .[dev] extra or add a test extra to pyproject.toml.

Useful? React with 👍 / 👎.

Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extras group "test" does not exist in pyproject.toml. The available extras are "dev", "docs", and "reports". Since the workflow runs pytest, this should likely be changed to ".[dev]" to install pytest and related testing dependencies, matching the pattern used in daily-build.yml workflow.

Suggested change
python -m pip install -e ".[test]"
python -m pip install -e ".[dev]"

Copilot uses AI. Check for mistakes.

- name: Run Tests
env:
Expand Down
Loading