fix outdated volatility3 dependency
#50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As quickly discussed with @Ston14 , this is a small trick in the
pyproject.tomlto force fetch the latest version of the Volatility3 using the original code base instead of the outdated package fromPiPy.Also note that
Volatility3installs the minimum dependencies as possible as a default (in itspyproject.toml) and uses adynamicfeature fromsetuptoolsto allow users to request the full installation of the framework.....feature witchpoetrydoes not have.So, as a workaround, I have simply dumped in our
pyproject.tomlall "optional" dependencies from theVolatility3 requirements.txt file]. This implies to always check in the future that this file has not been changed.Maybe using
git submodulecould help us avoid this maintaining task ?