Map revision (issue 59)

[Davidek523]

Code Pull Request Template

Summary

This PR ... addresses the issue of the incomplete map and the lack of animations. In this pr I revise the map by remaking the layers in Tiled and showing more layers in pygame/the game itself. I also extract the tiles that are ment to be used for animation and use the in the game. Also I took a ship, made it into a png file and replaced the red rectangle for player with the actual ship.

Related Issues

Map Revission issue #57

This PR issue(s) closes issue #57

---

✅ Checklist:

• 🛠️ I have tested my code, and it works as expected (e.g., game runs without errors).
• 📝 I have made sure that the code follows the project's formatting and style guidelines.

Optional:

• 💬 Code is commented (if applicable)

---

🏷️ Labels:

• type: ...
• area: ...
• game: ...

[ultimateownsz]

Hi @Davidek523,

Thank you for submitting this pull request. It’s clear that you’ve put effort into enhancing the map and animations, and I appreciate the work done to replace the red rectangle with a proper ship sprite—it’s a definite improvement in presentation. However, I noticed some issues that I’d like to address.

Observed issues

1. Player movement sprite bug

• When moving in certain directions, the player's sprite doesn't behave as espected:
  • Right: the sprite appears to break or is incorrectly displayed
    
  • Down: Similar issues occur when moving downward.
    
  • Left: when moving left, the sprite doesn't clearly show the direction you're heading

2. Loss of player directional feedback

   • The new animations are visually appealing, they seem to interfere with the player's directional feedback. The previous "ghost image" functionality that indicated direction is no longer working, making it unclear where the player is heading.

3. New issues #90

   • Additionally, the behavior described in #90 also occurs during testing. When the player sprite moves, it triggers unexpected or incorrect behaviors. This was also happening prior before the new animations.

4. Scope of the changes

   • This PR addresses the enhancements from #57 but may have introduced breaking changes that are impact related issues #58, #59 , and potentially #90. Could you clarify whether these issues are within the intended scope of this PR?

Questions for clarification

1. Is this PR meant to address only #57 , or should it resolve #58 , #59 , and #90 as well?
2. How do you plan to handle the directional feedback regression caused by the new animations?
3. Would it be possible to isolate the new animations so they don't interfere with the existing sprite mechanics?

Suggestion for improvement

• Player sprite direction: the player’s direction is clearly indicated should remain a priority. Could you revise the animation logic to preserve directional feedback while incorporating the new animations?
• Investigate whether the changes in this PR might be causing or exacerbating the behavior described in #90.
• If this PR is only partially addressing the linked issues, please update the description to reflect that and clearly define what is within scope.

[ultimateownsz]

Minor adjustments to the ship sprite and sea animation.

Looking good, minor things I noticed:

• Can you revert the ship sprite to the red square as it was before? Open a separate PR to address it with a new sprite, referring to issue #75. (might have to change the issue too or open a new one if none is existing).
• The ship movement is still broken, but that's unrelated to your PR, no need to address it in this scope (could be because with your current ship sprite it doesn't turn correctly when changing movements across the board).

Sea layer feedback:

• The current animation for the sea layer is a step in the right direction, but could you make the animation less wavy? It would be better if the motion was more subdued.
• Ideally, we could look into triggering sea animations only during turn transitions later on. This would reduce the animation activity and improve clarity during gameplay.

What do you think of this? @Davidek523

Thanks for the work so far—it's looking great!

[Davidek523]

@ultimateownsz I have seen your feedback. The ship sprite I think is not a major issue, it will take only one line of code to change (i hope so) as for the waves. Its not a easy task to do because we dont have other sprites in the assets that we are working with. Most of these sprites are 3 tiles of animation thats why it may seem as choppy and laggy. Unless you're asking me to make brand new assets for the waves and such, I can't fix this

EDIT:
What do you mean exactly by this?
"The ship movement is still broken, but that's unrelated to your PR, no need to address it in this scope (could be because with your current ship sprite it doesn't turn correctly when changing movements across the board)."
That when it goes east the ship faces west?

[ultimateownsz]

The changes look good, the camera movement doesn't work optimal yet like we priorly discussed but this is still not your fault and we pick it up in a new issue!