Skip to content

Add CodecContext global_quality property binding #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ladaapp wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

Add CodecContext global_quality property binding #2083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions av/video/codeccontext.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class VideoCodecContext(CodecContext):
qmin: int
qmax: int
type: Literal["video"]
global_quality: int

def encode(self, frame: VideoFrame | None = None) -> list[Packet]: ...
def encode_lazy(self, frame: VideoFrame | None = None) -> Iterator[Packet]: ...
Expand Down
18 changes: 18 additions & 0 deletions av/video/codeccontext.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,3 +368,21 @@ cdef class VideoCodecContext(CodecContext):
@qmax.setter
def qmax(self, value):
self.ptr.qmax = value

@property
def global_quality(self):
"""
Global quality for codecs which cannot change it per frame.
For example Intel QSV encoders like hevc_qsv.

Wraps :ffmpeg:`AVCodecContext.global_quality`.

:type: int
"""
FF_QP2LAMBDA = 118 # from avutil.h
return int(self.ptr.global_quality / FF_QP2LAMBDA)

@global_quality.setter
def global_quality(self, value):
FF_QP2LAMBDA = 118 # from avutil.h
self.ptr.global_quality = int(value * FF_QP2LAMBDA)
Loading