Add: command ~addcustomresponse #315#352
Open
aleaffallingintothedarkness-c12 wants to merge 1 commit intoPuzzleTechHub:mainfrom
Open
Conversation
Works the same as ~addcustomcommand except it's stored in the db with "RANDOM_RESPONSE:" prefix telling bot to treat it random if there is interest for weighted responses please tell me prefix is stored in `constants.py` removed by ~rmcustomcommand as it's just a custom function i think i got the aliasing correct PuzzleTechHub#315 could add functionality for random response if needed (borrow ~emoji)
Collaborator
Author
|
aleaffallingintothedarkness-c12
changed the title
aleaffallingintothedarkness-c12
changed the title
TheOriginalSoni
added
the
Ready for Review
Collaborator
|
Something about this implementation looks funky. There's no need to add a new constant for this, I'm not sure what this We could bunt it to post-MH26, we'll look at this properly and implement it well. |
TheOriginalSoni
added
Needs more work
Collaborator
Author
|
It writes to the custom command DB with the prefix so the bot knows it's a custom response It's a cheap implementation but the only way around it is by adding another another column in the DB I can do that if you'd like |
aleaffallingintothedarkness-c12
added
Ready for Review
Collaborator
|
Yes, let's add a new column for it. I don't like the current way, it's too clunky and not easy to extend if we want to expand functionality |
TheOriginalSoni
added
Needs more work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works the same as ~addcustomcommand except it's stored in the db with "RANDOM_RESPONSE:" prefix telling bot to treat it random
if there is interest for weighted responses please tell me
prefix is stored in
constants.pyremoved by ~rmcustomcommand as it's just a custom function
i think i got the aliasing correct
#315
could add functionality for random reaction if needed (borrow ~emoji)