Add form-level validations to Tramway forms #157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
normalizesso forms can validate inputs before saving.Description
lib/tramway/forms/validations.rbimplementingvalidates,validations, inheritance merging, and an__apply_validationsmethod.Tramway::BaseFormby requiring and including the module, initializing validations oninherited, applying validations during__submit, and makingsubmit/submit!respect validation errors.README.mdand guidance todocs/AGENTS.mdabout using form-levelvalidates.spec/dummy/app/formsto declare validations and addspec/forms/validations_form_spec.rbto exercise validation behavior and inheritance.Testing
spec/forms/validations_form_spec.rbcovering invalid attributes,allow_nilbehavior, and validation inheritance.bundle exec rspec spec/forms/validations_form_spec.rbbut the environment lackedbundler/rspecexecutables so the test run could not be executed here.Codex Task