feat: Preserve chronology of children when validating QREF #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstechly
reviewed
Feb 17, 2025
|
|
||
|
|
||
| def test_chronology_of_children_is_preserved_when_constructing_model_instances(): | ||
| # We used to sort children by name before we decided chronology is important. This test ensures that |
Contributor
There was a problem hiding this comment.
Could you find the right place to mention it in the docs as well?
Contributor
Author
There was a problem hiding this comment.
Excellent suggestion, I mentioned that we don't sort children in the docs, see 69e5b9d
mstechly
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to preserve chronology of children when computing highwater in Bartiq. However, the chronology is lost when we perform validation of
RoutineV1, because we sort children by name. This PR just removes the sorting.Note that all other functionalities we have here and in Bartiq don't rely on chronology, so this change should be non-breaking.
Please verify that you have completed the following steps