Assign some methods as properties#19
Draft
HarukaMa wants to merge 2 commits intoProvableHQ:masterfrom
Draft
Conversation
HarukaMa
changed the base branch from
fix/re-organize-python-account-methods
to
master
Contributor
Author
|
need to review and reconsider if methods from new classes should be changed as well. draft for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: depends on #18
Basically, to make the SDK more pythonic. Some methods like
account.address()could be written asaccount.address, as arguably address is a property of account. IMO we don't really need to keep the Rust semantics here.My criteria is:
RecordPlaintext.serial_number_string)As a side note,
to_stringmethods feels superfluous as users should just usestr(...)in Python to get a string representation of the object. I decided to not removing those here though.