docs(core): fix memory address column comment #421
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigmax
reviewed
Jan 16, 2026
| /// The relationships among `addr_word`, `addr_aligned`, and `addr_ls_two_bits` are as follows: | ||
| /// `addr_ls_two_bits` is the least significant two bits of the unaligned address. | ||
| /// `addr_aligned` is the aligned base address. | ||
| /// In the AIR, we constrain `reduce(addr_word) = addr_aligned + addr_ls_two_bits` and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The address layout comment in MemoryInstructionsColumns was misleading: it referenced an addr_offset field that doesn’t exist and implied the relationship still needed AIR verification. This change updates the comment to reflect the actual constraints used in the AIR (including the addr_word[0] & 0b11 lookup), so future edits don’t rely on outdated assumptions.