Refactor ProverClient::execute to borrow stdin #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
ProverClient::executeto accept&ZKMStdininstead of consuming ownership.Rationale:
In typical workflows, execute is often called alongside prove for debugging or gas estimation. Since prove also requires
stdin, consuming ownership in execute forced users to unnecessarilyclone()the input.Changes:
ZKMStdin.ProverClient::executeto take&ZKMStdin.stdin.clone()calls in examples and tests, eliminating unnecessary allocations.