Skip to content

Conversation

@lmorett1
Copy link

This PR changes ProverClient::execute to accept &ZKMStdin instead of consuming ownership.

Rationale:
In typical workflows, execute is often called alongside prove for debugging or gas estimation. Since prove also requires stdin, consuming ownership in execute forced users to unnecessarily clone() the input.

Changes:

  • Updated the Execute builder to hold a reference to ZKMStdin.
  • Refactored ProverClient::execute to take &ZKMStdin.
  • Removed redundant stdin.clone() calls in examples and tests, eliminating unnecessary allocations.

@VanhGer
Copy link
Contributor

VanhGer commented Jan 14, 2026

In some other examples, stdin.clone() is still present. For example, see examples/rsa/host/src/main.rs.
Please update them as well.

@lmorett1
Copy link
Author

In some other examples, stdin.clone() is still present. For example, see examples/rsa/host/src/main.rs. Please update them as well.

@VanhGer Done. I've updated the RSA example and all other examples in the repo to remove stdin.clone().

@eigmax eigmax changed the base branch from main to pre-release-v1.2.4 January 16, 2026 01:48
@eigmax eigmax changed the base branch from pre-release-v1.2.4 to main January 16, 2026 02:26
@eigmax
Copy link
Member

eigmax commented Jan 16, 2026

Thanks! it affects all the applications upon Ziren and we also need to double review if all use cases are appliable, I will merge it after v.1.2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants