Reorganization and introducing Plant as a type#91
Merged
anchal-physics merged 3 commits intomasterfrom Jul 22, 2025
Merged
Conversation
Plant is now an Abstract Type just like Actuators and Controllers. It will also be callable and should hold any input conditioning inside it. The InputConditioning is provided as an Abstract Type also and now system_id and system_id_optimal_inp_cond both return a Plant object directly. Note that plant now holds the state of the plant, so it should be used carefully. model_evolve will use a deepcopy of passed plant object so that it doesn't affect the state of the plant.
actuators.jl - Fixed DelayedActuator so that it works for zero delay also. controllers.jl - PVLC and MPC now are limited to LinearPlant as they use `state_prediction_matrices`. - Both PVLC and MPC now do `offset_scale` before using `state_prediction_matrices`. - MPC has options of guess and curve_fit_kwargs now. - run_closed_loop_sim does deepcopy on plant, act, and ctrl inside now, so it runs a on a copy of the models. system_id.jl - Added curve_fit_kwargs now
Plant is now an Abstract type with input conditioning being a type as well. PVLC and MPC have been upgraded accordingly. This makes the architecture more consistent.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
==========================================
- Coverage 87.37% 87.21% -0.17%
==========================================
Files 6 9 +3
Lines 935 970 +35
==========================================
+ Hits 817 846 +29
- Misses 118 124 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing v2.2.2
Plant is now an Abstract Type just like Actuators and Controllers. It
will also be callable and should hold any input conditioning inside it.
The InputConditioning is provided as an Abstract Type also and now
system_id and system_id_optimal_inp_cond both return a Plant object
directly.
PVLC and MPC have been updated.