Improve h_mode_detector to use core average instead of single point#291
Open
nanshi1177 wants to merge 1 commit intomasterfrom
Open
Improve h_mode_detector to use core average instead of single point#291nanshi1177 wants to merge 1 commit intomasterfrom
nanshi1177 wants to merge 1 commit intomasterfrom
Conversation
Issue first identified in DIII-D shot #200000. Previously, h_mode_detector used a single reference point calculated from pedestal width (rho1 = rho0 - 2*rhoσ). This was unreliable because: - The reference point location was arbitrary - If it landed on a local flat spot, it could falsely trigger H-mode detection Changes: - Use average inverse scale length in core region (rho < 0.7) instead of single point - Compare core average to max gradient (at pedestal) - More robust detection that doesn't depend on pedestal width calculation - Updated default threshold from 0.4 to 0.3 to match new method - Updated diagnostic plot to show core boundary and core average Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue first identified in DIII-D shot #200000.
Previously, h_mode_detector used a single reference point calculated from pedestal width (rho1 = rho0 - 2*rhoσ). This was unreliable because:
Changes: