You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is to "explain" the detailed procedures when executing onetime or dynamic expressions in dd, which is to address the issue raised from the code camp (see Backend/user interace section in ProjectTorreyPines/FUSE.jl#786).
@orso82 I am glad that you like this feature, and thanks for saying highly :)
I've tried to move expr_info.jl to under the IMASdd.jl, but the @store_expr macro defined in expr_info.jl does not work as expected.
The issue seems to be the different scopes of @store_expr, such that it is defined in the IMASdd scope but used in the IMAS scope, leading to some tricky conflict.
Hence, at the moment, I think we can allow expr_info.jl to live in the IMAS package, like onetime.jl and dynamic.jl.
FYI, if I move all three files (expr_info.jl, onetime.jl, dynamic.jl) to under the IMASdd, the new macros work as expected, except for some expressions that use functions defined in IMAS package.
So for now, it seems safe to set all three files as bound to the IMAS package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to "explain" the detailed procedures when executing
onetimeordynamicexpressions in dd, which is to address the issue raised from the code camp (seeBackend/user interacesection in ProjectTorreyPines/FUSE.jl#786).The more details and examples are described in the following PR:
ProjectTorreyPines/FUSE.jl#794
Dependency / Related PRs
This change depends on related PR in the
IMASddpackage to fully function:ProjectTorreyPines/IMASdd.jl#47
Note