-
Notifications
You must be signed in to change notification settings - Fork 2
Dev #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jayrhie
wants to merge
299
commits into
ViewMyReference
Choose a base branch
from
dev
base: ViewMyReference
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
응답 데이터 형식 변경:
피드백의 좋아요 여부 isLiked, likeCount는 제거하였습니다
대신 피드백 단 멤버에 isLiked, likeCount 필드가 추가되었습니다.
(레퍼런스 상세보기, 피드백 관련 api후 응답 JSON형태에 변화가 적용됨)
피드백 대댓글의 좋아요 여부 isLiked는 그대로 두었습니다.
피드백 부분 api 엔드포인트 변경:
피드백 좋아요 수행시 피드백 작성한 멤버 id를 경로변수에 포함시켜 주셔야 합니다.
피드백 수정, 삭제시에는 원래 {feedback_id}만 경로변수에 있었습니다만,
{reference_id}도 경로변수에 올 수 있도록 수정하였습니다 -> swagger 참고해주세요
isFeedback -> isComment로 불리언 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.