This repository was archived by the owner on Sep 15, 2022. It is now read-only.
Move dependencies around, only distribute npm items in lib/.#3
Open
SirensOfTitan wants to merge 2 commits intoProjectOpenSea:masterfrom
Open
Move dependencies around, only distribute npm items in lib/.#3SirensOfTitan wants to merge 2 commits intoProjectOpenSea:masterfrom
SirensOfTitan wants to merge 2 commits intoProjectOpenSea:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves dependencies around to reduce full size of distribution of package, and only includes compiled files in npm package.
Not including dependency savings (which will be very large for this particular project as wyvern-js depends on typescript in dependencies, where it should be a devDependency only.
Test Plan
yarn linkwyvern-js into wyvern-schemaswyvern-schemasbuildsyarnand testsyarn testwith all greens.