Add regression tests for zero-speed segment updates#7341
Open
afarber wants to merge 5 commits intoProject-OSRM:masterfrom
Open
Add regression tests for zero-speed segment updates#7341afarber wants to merge 5 commits intoProject-OSRM:masterfrom
afarber wants to merge 5 commits intoProject-OSRM:masterfrom
Conversation
bc89327 to
f0eddec
Compare
f0eddec to
748ec17
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect routing/turn behavior when closing segments via --segment-speed-file during MLD customization, attributed to concurrent turn-penalty updates.
Changes:
- Add mutex-based synchronization around a turn-penalty write during parallel edge updates in the updater.
- Add Cucumber scenarios covering “closure shouldn’t cascade” routing regressions.
- Add an Unreleased changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/updater/updater.cpp | Introduces mutex/lock guard around a turn_weight_penalties update during tbb::parallel_for. |
| features/testbot/zero-speed-updates.feature | Adds regression scenarios to ensure closures don’t block turns at unrelated intersections or cascade to parallel routes. |
| CHANGELOG.md | Adds an Unreleased entry describing the fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Hi, I misunderstood how I have updated the PR title and description and feel free to close if not useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Add Cucumber scenarios to verify that closing segments via
--segment-speed-filedoesn't incorrectly block turns at unrelated intersections or cascade to parallel routes.Also add a unit test documenting the turn_id uniqueness invariant and improves the turn penalty warning log.
Tasklist
Requirements / Relations
Related to #7332