First update #3
First update #3
Conversation
ToscaBeijaert
left a comment
ToscaBeijaert
left a comment
There was a problem hiding this comment.
Hey hey,
Generally I would say, try to add some more comments in your code so we can follow what's going on. So even besides docstrings for classes and function, inside the classes and functions try to add some text on what is happening. Keep it up!
| Because if the wrong notes are loaded, the whole programm doesn't work. | ||
| """ | ||
|
|
||
| def test_read_launchpad(self): |
There was a problem hiding this comment.
I think it would be nice if you add some general comments about what is going on per function as well. Or if you make it really fancy, you add a docstring for the functions in these classes as well (but a lot of effort).
There was a problem hiding this comment.
Because now I'm not certain what is going on, I guess you are check whether 2 things are the same with self.assert.Equal, but what precisely you are checking, I am not sure
| @@ -0,0 +1,322 @@ | |||
| { | |||
There was a problem hiding this comment.
I am not entirely sure what exactly this notebook does, so maybe it's a good idea to add some general explanation of what this notebook does at the top of the code? I am guessing that when you made this, you made it mostly for yourself and therefore didn't document a lot, which I also tend to do quite often... :(
I added a testing unit.
I also created another branch called experimental which has a PySide/QtPy interface