update_week3 #6
Open
update_week3 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a function for calling a random image in notes_test, and created a test for this function in test_notes Under TestRandomNote
ToscaBeijaert
left a comment
ToscaBeijaert
left a comment
There was a problem hiding this comment.
Hey hey,
I think you should add some docstrings and some parameter info and some general comments about what exactly it is you are doing. This way other people will be able to follow what is going on as well :)
| from PIL import ImageTk, Image | ||
| from random import randint | ||
|
|
||
| def imagegen(numb, imagelist): |
There was a problem hiding this comment.
Maybe add some dostring here to what it does and what parameters are needed and what it returns.
For example:
def imagegen(numb, imagelist) -> musical_notes.........: ( --> shows what it returns)
""" Some info of what this function does
:param numb: info about parameter
:type numb: info of what kind of parameter it is
... etc
... etc
"""
| widget=Widget('answer_box') | ||
| self.assertEqual(widget.size(), (50, 50)) | ||
|
|
||
| class TestRandomNote(unittest.TestCase): |
There was a problem hiding this comment.
idem ditto, add some dostrings and parameter info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main file = notes_test
unittest file = test_notes
Update: Created a function for calling a random image in notes_test, and created a test for this function in test_notes under TestRandomNote.