Open
Conversation
levyishai
requested changes
Nov 9, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 13, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
levyishai
requested changes
Nov 13, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 14, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
levyishai
requested changes
Nov 14, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
levyishai
reviewed
Nov 15, 2023
Member
levyishai
left a comment
There was a problem hiding this comment.
Start working on the subsystem
Nummun14
reviewed
Nov 19, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
levyishai
requested changes
Nov 22, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 22, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 23, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
Nummun14
reviewed
Nov 23, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 26, 2023
levyishai
reviewed
Nov 26, 2023
Member
levyishai
left a comment
There was a problem hiding this comment.
Make a command to set the target state, which will have a byOrder param. If this is true, make the side shooter reach the target angle, and then shoot. If this is false, do them in parallel to each other.
levyishai
requested changes
Nov 30, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Dec 2, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Dec 4, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
levyishai
requested changes
Dec 5, 2023
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooterConstants.java
Show resolved
Hide resolved
levyishai
requested changes
Dec 21, 2023
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/sideshooter/SideShooter.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.