Conversation
levyishai
requested changes
Nov 8, 2023
src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/armConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 9, 2023
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 9, 2023
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 9, 2023
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 9, 2023
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Nov 11, 2023
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/ArmConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Dec 18, 2023
...main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/TurretCommands.java
Outdated
Show resolved
Hide resolved
levyishai
reviewed
Dec 19, 2023
Member
There was a problem hiding this comment.
Read about MotionMagic and implement it in the code. This is why you didn't use profiles for the rest of the clas yet. (Note that the simulation will use profiles in order to match what motion magic does.)
And in second thought, use a mechanism for now to visualize until you can have the full robot visualization.
levyishai
requested changes
Dec 19, 2023
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Dec 21, 2023
src/main/java/frc/trigon/robot/subsystems/turret/TurretConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java
Show resolved
Hide resolved
...main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Dec 21, 2023
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Show resolved
Hide resolved
levyishai
requested changes
Dec 24, 2023
src/main/java/frc/trigon/robot/subsystems/turret/TurretCommands.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/kablamaturret/KablamaTurretIO.java
Outdated
Show resolved
Hide resolved
...main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretConstants.java
Show resolved
Hide resolved
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Outdated
Show resolved
Hide resolved
levyishai
requested changes
Dec 24, 2023
src/main/java/frc/trigon/robot/subsystems/turret/simulationturret/SimulationTurretIO.java
Outdated
Show resolved
Hide resolved
Member
Author
Member
Member
Author
Member
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.