Better Controls

[Strflightmight09]

No description provided.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• ✅ Review completed - (🔄 Check again to review again)

Walkthrough

Adds debounce and double-tap timing constants and converts multiple button triggers to require multi-press timing; adds a debounced CAMERAS_DISCONNECTED_TRIGGER (backed by RobotPoseEstimator.hasUpdateFromCameras()) and binds it to a new INDICATE_CAMERAS_DISCONNECTED_COMMAND that rumbles the driver controller. RobotPoseEstimator now tracks hasUpdateFromCameras and renamed initialize() to initializeFieldWidget(). Exposes ClimbCommands.IS_CLIMBING as a LoggedNetworkBoolean, adjusts climb commands/state names (CLIMB_PREPARE→PREPARE_CLIMB, CLIMB_DOWN→RELEASE_CLIMB), adds ignoreDisable on some intake commands, and switches a Swerve synchronization lock.

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Better Controls' refers to a real aspect of the changeset (enhanced control trigger behavior) but is vague and doesn't convey the specific changes made.	Use a more descriptive title like 'Add camera disconnect detection and multi-press controls' to clearly communicate the main changes.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a description explaining the key changes: camera disconnection detection, multi-press trigger enhancements, climb command refactoring, and synchronization updates.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 3

[yinondahan]

nitzahon mefoar

[yinondahan]

nitzahon mefoar

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 2

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 3

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/main/java/frc/trigon/robot/misc/MatchTracker.java (1)

48-57: 🧹 Nitpick | 🔵 Trivial

Extract the shift boundaries into named constants.
This removes magic numbers and clarifies the time windows.

As per coding guidelines: Magic numbers and strings should be named constants.