Open
Conversation
Works much faster and fixes unknown error when database becomes large.
Author
|
I am sorry, it breaks the search. Error is: I tried this. but now it is again slow as before: if empty(frm, itr=True):
query = query.order_by(index=r_order)
else:
query = query.order_by(r_order)
query = query.skip(offset).limit(limit)I will try something else. |
Author
|
Fixed. Without search it uses index and it is very fast. When searching, it works like before. |
Check my fork.. Work is still in progress however. |
Author
|
Wow, you did so many other improvements. Do you need this change for your fork also? |
If this will make queries faster you could make a PR and I will test it. ;) Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works much faster and fixes unknown error when database becomes large.
As I can see there is no option to change ordering, it is always on
last_attemptfield, onlyasc/descmay change. The index was already created, so just use it.