Fix the link since the page migration

[Touxten]

Questions	Answers
Description?	Fix the link from the page migration?
Type?	bug fix
BC breaks?	no
Deprecations?	no
Fixed ticket?	PrestaShop/PrestaShop#39185
Sponsor company	@friends-of-presta
How to test?	See issue

[SiraDIOP]

Qa by Dev

[Hlavtox]

@SiraDIOP You can test it just fine yourself, really. Just verify that all buttons in module settings work fine.

[Hlavtox]

Ping @PrestaShop/qa-functional @PrestaShop/committers for QA, this is required for this module to work on 9.0.x branch on NGINX.

[jolelievre]

I think this should be fixed on the core level not on all modules, I struggled to ake this backwatd compatible and it works in most cases I guess from the issue that nginx is a special case but it also needs to be handled

If there is no other solution we'll fix it on the module level, but first we need to try and handle this on the core level

[Hlavtox]

@jolelievre Double index.php in the URL is a wrongly constructed URL.

https://www.domain.cz/admin/index.php/improve/modules/manage/action/configure/index.php?controller=AdminModules&configure=ps_categorytree&token=abc&conf=6

Yes, the core CAN handle it, but the module should link to a proper URL. It's the modules "fault" that it routed to fragile relative URL for years.

[kpodemski]

@Hlavtox the thing is that AdminController::$currentIndex is not only used for that, but also some other things, so it has to be fixed anyway 👍🏻

but, to be honest, I think this PR doesn't need to be blocked @jolelievre

[Touxten]

Ok i can change and use the third parameters.

However, why not merge all PRs and afterthen use the third parameter?

Since the release of 9.0.0, these modules have been unusable, and the PRs date back to July.

PrestaShop/PrestaShop#39185 (comment)

[arkpoah]

I get a 404 error when I add tracking id in module configuration, I think it is linked to this issue.
Is there a workaround to add the tracking id waiting the fix ? Where should add it in database for PS9 ?

[Hlavtox]

@jolelievre It's ready Jo, check it out. The params need to be provided properly, so I did it. :-)

Changes applied per request

[Quetzacoalt91]

@SiraDIOP I beleve you're now able to do the QA review?

[SiraDIOP]

Hello @Touxten,

Thanks for your PR, I tested the module on nginx server and it's good for me

Thanks

[ps-jarvis]

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.