Skip to content

Address code review comments: fix asset paths, harden security, improve documentation#303

Merged
dmccoystephenson merged 4 commits intofeat/server-clientfrom
copilot/sub-pr-266
Feb 1, 2026
Merged

Address code review comments: fix asset paths, harden security, improve documentation#303
dmccoystephenson merged 4 commits intofeat/server-clientfrom
copilot/sub-pr-266

Conversation

Copy link

Copilot AI commented Feb 1, 2026

Addresses 6 issues flagged in automated code review covering asset path bugs, security vulnerabilities, and unclear configuration documentation.

Asset Path Corrections

  • Fixed DeerMeat.java using chicken.png instead of deerMeat.png
  • Aligned stone.py client to use stone.png matching server (was stone_item.png)

Security Hardening

  • Removed localhost:8080 from CORS allowed origins (prevents self-XSS attacks)
  • Changed compose-db-only.yml to require explicit POSTGRES_PASSWORD (no weak default)
  • Enhanced backup-db.sh password validation:
    • Case-insensitive blacklist matching
    • Expanded weak password list (password123, admin123, roam123, roamdev, etc.)
    • Safe variable expansion handling for ${DB_USER} and ${DB_NAME}

Documentation

  • Clarified application.yml auto-save comment with explicit tradeoff: manual saves required when disabled, data loss risk on crashes

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits February 1, 2026 22:47
…e documentation

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
… weak password list

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
…k password list

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Docker-based development workflow for Roam project Address code review comments: fix asset paths, harden security, improve documentation Feb 1, 2026
@dmccoystephenson dmccoystephenson marked this pull request as ready for review February 1, 2026 22:59
@dmccoystephenson dmccoystephenson merged commit 16ab47f into feat/server-client Feb 1, 2026
2 checks passed
@dmccoystephenson dmccoystephenson deleted the copilot/sub-pr-266 branch February 1, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants