Conversation
Author
|
I think this pane PR ties in well with the discussion about global selectors vs. memoized component calculations. Do you know of a way to calculate and memoize the derived data for each pane using a global selector? To be clear, if one pane changes its |
introduce collection reducers
Member
|
For posterity: This is the good one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jgautsch
Here is a first stab at adding panes. I think there are several ways it could be improved.
However, the first thing to improve is that it isn't actually memoizing the matchingVisibleTodos for each pane individually --- so if you change the search term in one pane, it recalculates for all panes.
I'm not immediately sure how to build a
reselectselector to address this issue. Any ideas?